Issue490963

classification
Title: Please update ReadlineConsole.java
Type: Severity: normal
Components: Core Versions:
Milestone:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: bckfnn Nosy List: bab, bckfnn
Priority: normal Keywords:

Created on 2001-12-09.23:44:13 by bab, last changed 2001-12-10.20:39:26 by bckfnn.

Files
File name Uploaded Description Edit Remove
patch_ReadlineConsole.p bckfnn, 2001-12-10.18:29:02 Patch to ReadlineConsole
Messages
msg517 (view) Author: Ben Burton (bab) Date: 2001-12-09.23:44:13
Hi.  Bablok's readline classes have been updated
and the new interface is incompatible with the old.
Below is a patch for org/python/util/ReadlineConsole.java
that uses the new (0.6) interface.

Thanks - Ben.

--- jython-2.1-beta1.orig/org/python/util/ReadlineConsole.java
+++ jython-2.1-beta1/org/python/util/ReadlineConsole.java
@@ -17,6 +17,10 @@
     }
     public ReadlineConsole(PyObject locals, String filename) {
         super(locals,filename);
+        try {
+           Readline.load(ReadlineLibrary.Editline);
+        } catch (RuntimeException e) {
+        }
         Readline.initReadline("jpython");
     }

msg518 (view) Author: Finn Bock (bckfnn) Date: 2001-12-10.18:29:01
Logged In: YES 
user_id=4201

Thanks.

I'm not certain that it is a good thing to hardcode the use 
of the Editline library. I have attached a patch that 
hopefull allow switching between native libraries using a 
registry setting. I can't test this on win2k so please 
check if the patch works for you.
msg519 (view) Author: Ben Burton (bab) Date: 2001-12-10.18:51:59
Logged In: YES 
user_id=146613

> please check if the patch works for you.

Works for me.

Thanks for that - b.
msg520 (view) Author: Finn Bock (bckfnn) Date: 2001-12-10.20:39:26
Logged In: YES 
user_id=4201

Fixed in ReadlineConsole.java: 1.5;
History
Date User Action Args
2001-12-09 23:44:13babcreate