Message2814

Author cgroves
Recipients
Date 2007-09-22.19:13:34
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
It makes more sense for this check to live in __findattr__(PyString) instead of __findattr__(String).  The first place would allow you to do an instanceof PyUnicode check instead of making a PyString out of every String that comes in to __findattr__.  __findattr__ is used from all over the place, so slowing it down is a bad idea.  If some Java code is calling __findattr__(String) with unicode Strings, this should be fixed there rather than in PyObject.  

Also, you're using tabs rather than spaces for indentation.
History
Date User Action Args
2008-02-20 17:18:46adminlinkissue1775263 messages
2008-02-20 17:18:46admincreate