Message3999

Author	fwierzbicki
Recipients	fwierzbicki, njoyce
Date	2009-01-03.02:44:34
SpamBayes Score	4.2779775e-06
Marked as misclassified	No
Message-id	<1230950674.89.0.47453071956.issue1217@psf.upfronthosting.co.za>
In-reply-to

Content
Thanks for reporting the bug and taking a crack at a patch! If you where to add a test (probably in Lib/test/test_zlib.py) it would make it much easier for me to accept and apply a patch. Also, wouldn't it be better to put the try block in _get_inflate_data since that method gets called in a few places? And while you are looking at it _get_deflate_data probably has a similar issue.

Thanks for reporting the bug and taking a crack at a patch!

If you where to add a test (probably in Lib/test/test_zlib.py) it would
make it much easier for me to accept and apply a patch.

Also, wouldn't it be better to put the try block in _get_inflate_data
since that method gets called in a few places?  And while you are
looking at it _get_deflate_data probably has a similar issue.

History
Date	User	Action	Args
2009-01-03 02:44:34	fwierzbicki	set	messageid: <1230950674.89.0.47453071956.issue1217@psf.upfronthosting.co.za>
2009-01-03 02:44:34	fwierzbicki	set	recipients: + fwierzbicki, njoyce
2009-01-03 02:44:34	fwierzbicki	link	issue1217 messages
2009-01-03 02:44:34	fwierzbicki	create