Message4049

Author cgroves
Recipients cgroves, garyh
Date 2009-01-16.09:21:40
SpamBayes Score 0.0026285292
Marked as misclassified No
Message-id <1232097701.43.0.730678871521.issue1232@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the patch and test; it made fixing this quite easy.  I've
committed a fix for this to trunk in r5936, though I used a different
approach than the one in the patch.

Using the full set of methods from the super class as you did would
change the available bean property if a subclass defined a setter with a
different type than the superclass.  I believe the subclass' version
should be used regardless, so the committed version checks for
PyBeanProperties with the same name in superclasses when adding a
PyBeanProperty.  If it finds one, and the subclass is missing a getter
or setter for that name, it's filled in.  The methods array isn't
changed at all.

In any case, your test passes now and has been added to our regression
test, so this shouldn't break again.
History
Date User Action Args
2009-01-16 09:21:41cgrovessetmessageid: <1232097701.43.0.730678871521.issue1232@psf.upfronthosting.co.za>
2009-01-16 09:21:41cgrovessetrecipients: + cgroves, garyh
2009-01-16 09:21:41cgroveslinkissue1232 messages
2009-01-16 09:21:40cgrovescreate