Message4759

Author zyasoft
Recipients fwierzbicki, pjenvey, undefined, zyasoft
Date 2009-05-29.14:10:44
SpamBayes Score 1.876158e-08
Marked as misclassified No
Message-id <1243606245.11.0.653343700182.issue1355@psf.upfronthosting.co.za>
In-reply-to
Content
The patch looks fine to me, and not so inefficient (small constant
factors here). But if you want to squeeze a bit more w/o too much work:

Allocate the StringBuilder buffer a smaller multiple, 10x is way too
much. I think 1x should be fine, this will be optimal for unescaped
ascii strings and for the rest, StringBuilder should converge pretty
quickly to the right size anyway.

toCodePoints is just a wrapper of PyUnicode.newSubsequenceIterator, so
you can avoid one extra loop.
History
Date User Action Args
2009-05-29 14:10:45zyasoftsetmessageid: <1243606245.11.0.653343700182.issue1355@psf.upfronthosting.co.za>
2009-05-29 14:10:45zyasoftsetrecipients: + zyasoft, fwierzbicki, pjenvey, undefined
2009-05-29 14:10:44zyasoftlinkissue1355 messages
2009-05-29 14:10:44zyasoftcreate