Message6448

Author pjenvey
Recipients pjenvey, yole
Date 2011-03-22.02:43:03
SpamBayes Score 2.2702244e-07
Marked as misclassified No
Message-id <1300761783.45.0.9192549331.issue1718@psf.upfronthosting.co.za>
In-reply-to
Content
I applied some minor changes, mostly coding standards in r7261

The only other suggestion I might make is to maybe have the internal stringlib classes throw Py.ValueErrors instead of InvalidArgumentExceptions which propagate up as ValueErrors anyway

To limit recursion you probably just need to surround those potential recursive calls in:

threadState.enterRecursiveCall(" in foo");
try {
    recursiveCall.__call__()
} finally {
    threadState.leaveRecursiveCall();
}

To handle subclasses overriding __format__ we probably just need an entry for __format__ added to src/templates/object.derived and to regenerate our derived subclasses with gderved.py in the same directory
History
Date User Action Args
2011-03-22 02:43:03pjenveysetmessageid: <1300761783.45.0.9192549331.issue1718@psf.upfronthosting.co.za>
2011-03-22 02:43:03pjenveysetrecipients: + pjenvey, yole
2011-03-22 02:43:03pjenveylinkissue1718 messages
2011-03-22 02:43:03pjenveycreate