Message7448
Kabir: The patch looks good in relation to the changes to OS.py, which correctly lowercases the OS name.
But the changes to PyString should not be necessary, because they would affect lower-casing of all strings, which would be wrong for non-English locales.
http://docs.oracle.com/javase/6/docs/api/java/lang/String.html#toLowerCase%28%29
Do you find in your testing that the bug is not fixed, in relation to JBoss AS, when you only patch OS.java? Must you apply the PyString.java changes also to fix the issue? I expect not. |
|
Date |
User |
Action |
Args |
2012-08-28 21:55:22 | amak | set | messageid: <1346190922.48.0.219543070733.issue1874@psf.upfronthosting.co.za> |
2012-08-28 21:55:22 | amak | set | recipients:
+ amak, fwierzbicki, jjaggars, miclark, kabir |
2012-08-28 21:55:22 | amak | link | issue1874 messages |
2012-08-28 21:55:22 | amak | create | |
|