Message7615

Author jeff.allen
Recipients amak, fwierzbicki, jeff.allen, kevinmcmurtrie
Date 2013-02-04.21:35:59
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1360013759.75.0.519172625923.issue1967@psf.upfronthosting.co.za>
In-reply-to
Content
Frank:

I've played around with this, educating myself on io. I don't think I got any further than you, Kevin and Alan, but I don't understand what the outstanding problem is when you seemed so close.

The original motivation for the change was #1754. The changeset:
http://hg.python.org/jython/rev/bf3a1d3eae8c
introduced a custom Channel implementation intoStreamIO as a way of addressing Issue 1754. But by Alan's report that has been addressed a better way. Alan was wary of simply reversing the whole of that change as it contains some apparently useful unconnected change.

I confirmed that if I remove the custom Channel implementation from StreamIO it seems to fix the issue (and others), in 2.7 at least. Can't we just do that?

test_io_jy then fails, but I question the validity of that test, as it seems to test directly that StreamIO behaves in the way thought to be the solution to the problem, but which in fact has unwelcome side effects. I think Alan's work also provides the relevant test (of the modjy behaviour). It would be nice have this work in 2.7b as I miss InteractiveConsole (#1962) and I think it also fixes #1972. Others want it in 2.5.x, of course.
History
Date User Action Args
2013-02-04 21:35:59jeff.allensetmessageid: <1360013759.75.0.519172625923.issue1967@psf.upfronthosting.co.za>
2013-02-04 21:35:59jeff.allensetrecipients: + jeff.allen, fwierzbicki, amak, kevinmcmurtrie
2013-02-04 21:35:59jeff.allenlinkissue1967 messages
2013-02-04 21:35:59jeff.allencreate