Title: socket.IPPROTO_TCP=6 missing constant for socket module
Type: behaviour Severity: minor
Components: Library Versions: 2.5b0
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: amak Nosy List: amak, cocoon, fwierzbicki, pjenvey, zyasoft
Priority: high Keywords:

Created on 2008-12-05.18:01:33 by cocoon, last changed 2009-04-08.10:27:22 by amak.

File name Uploaded Description Edit Remove
socket_ipproto.patch zyasoft, 2008-12-29.18:23:27
msg3872 (view) Author: cocoon (cocoon) Date: 2008-12-05.18:01:32
import socket;socket.IPPROTO_TCP=6 solve the problem, the socket module
behaviour is correct if we set this option
msg3986 (view) Author: Jim Baker (zyasoft) Date: 2008-12-29.17:52:02
cherrypy 3.1.1 uses socket.IPPROTO_TCP; by defining the constant,
soaplib at the very least is able to run all of its unit tests.

(The cherrypy test suite involves tty, so at the very least that needs
to be looked at - I don't think we want to consider supporting tty too
just yet :)

Constantine defines socket protocol constants in
org.python.constantine.platform.IPProto, so hopefully it should be
straightforward to add.
msg3987 (view) Author: Jim Baker (zyasoft) Date: 2008-12-29.18:23:27
Added a patch to import the desired ipproto constants from Constantine
(for now just IPPROTO_TCP, not certain if we want to pull all of them in).
msg4421 (view) Author: Jim Baker (zyasoft) Date: 2009-04-04.01:55:50
Should this be a blocker for RC? Or wait until 2.5.1?
msg4430 (view) Author: Jim Baker (zyasoft) Date: 2009-04-04.02:47:57
This would also enable Pylons on CherryPy
msg4437 (view) Author: Alan Kennedy (amak) Date: 2009-04-04.15:16:58
Fixed in trunk at r6159.
msg4477 (view) Author: Philip Jenvey (pjenvey) Date: 2009-04-08.01:12:10
Reopening because we (in particular cherrypy wsgiserver) needs this 
supported for server sockets

Since the Java ServerSocket doesn't support setTcpNoDelay I suppose we'd 
have to delay setting the option until the server accept()s and produces 
a normal Socket object? Then we'd then set no delay on that? blah
msg4481 (view) Author: Alan Kennedy (amak) Date: 2009-04-08.10:27:22
Closing this again.

Philips' point about setting client options on server sockets and
propagating them client to 'accept'ed clients is an important one, but
this bug is not the place to discuss it.

I have created a new RFE where this issue can be discussed.

Server sockets do not support client options and propagate them to
'accept'ed client sockets.
Date User Action Args
2009-04-08 10:27:22amaksetstatus: open -> closed
keywords: - patch
resolution: fixed
messages: + msg4481
2009-04-08 01:12:11pjenveysetstatus: closed -> open
resolution: fixed -> (no value)
messages: + msg4477
2009-04-04 15:16:58amaksetstatus: open -> closed
assignee: zyasoft -> amak
resolution: fixed
messages: + msg4437
2009-04-04 02:47:57zyasoftsetpriority: high
assignee: amak -> zyasoft
messages: + msg4430
nosy: + fwierzbicki, pjenvey
2009-04-04 01:55:50zyasoftsetmessages: + msg4421
2008-12-29 18:23:28zyasoftsetfiles: + socket_ipproto.patch
keywords: + patch
messages: + msg3987
2008-12-29 17:52:02zyasoftsetnosy: + zyasoft
messages: + msg3986
2008-12-24 13:18:14amaksetassignee: amak
nosy: + amak
2008-12-05 18:01:33cocooncreate