Issue1395
Created on 2009-07-03.15:32:29 by MrMeanie, last changed 2010-08-04.17:22:52 by zyasoft.
|
| msg4879 (view) |
Author: Geoffrey French (MrMeanie) |
Date: 2009-07-03.15:32:28 |
|
PyList.indexOf() and PyTuple.indexOf() fail due to not wrapping the
incoming Java object before passing to the indexOf() method of the
underlying container.
tests/java/javatests/ListTest.java contains a test method called
indexOf() to test this method, however, it is not called by testAll();
it is never used.
Please find attached a patch that:
- renames ListTest.indexOf() to ListTest.test_indexOf()
- calls ListTest.test_indexOf() from ListTest.testAll()
- Fixes PyList.indexOf()
- Fixes PyTuple.indexOf()
Passes regression tests.
|
| msg4888 (view) |
Author: Philip Jenvey (pjenvey) |
Date: 2009-07-08.00:51:08 |
|
Simple fix, looks very straightforward. Over to Jim
|
| msg5936 (view) |
Author: Geoffrey French (MrMeanie) |
Date: 2010-08-04.13:00:18 |
|
This issue has been addressed.
The ListTest.java test still does not test the indexOf() method. My patch will fix this.
|
| msg5940 (view) |
Author: Jim Baker (zyasoft) |
Date: 2010-08-04.17:22:52 |
|
Test enabled in r7084, finally closing this bug.
|
|
| Date |
User |
Action |
Args |
| 2010-08-04 17:22:52 | zyasoft | set | status: open -> closed
resolution: fixed
messages:
+ msg5940 |
| 2010-08-04 13:00:18 | MrMeanie | set | messages:
+ msg5936 |
| 2010-02-05 20:01:19 | fwierzbicki | set | nosy:
+ fwierzbicki |
| 2009-07-08 00:51:08 | pjenvey | set | assignee: zyasoft
messages:
+ msg4888
nosy:
+ pjenvey, zyasoft |
| 2009-07-03 15:32:29 | MrMeanie | create | |
|
