Issue1642

There is an error when the argument and zero in jsr223 proxy! correction follows below.


Index: src/org/python/jsr223/PyScriptEngine.java
===================================================================
--- src/org/python/jsr223/PyScriptEngine.java	(revisão 7093)
+++ src/org/python/jsr223/PyScriptEngine.java	(cópia de trabalho)
@@ -144,7 +144,13 @@
                         PyObject pyMethod = thiz.__findattr__(method.getName());
                         if (pyMethod == null)
                             throw new NoSuchMethodException(method.getName());
-                        PyObject result = pyMethod.__call__(Py.javas2pys(args));
+
+                        PyObject result;
+                        if(args != null) {
+                            result = pyMethod.__call__(Py.javas2pys(args));
+                        } else {
+                            result = pyMethod.__call__();
+                        }
                         return result.__tojava__(Object.class);
                     } catch (PyException pye) {
                         throw scriptException(pye);

This patch looks reasonable to me. Would you mind adding some unit tests, so we can see all the expected cases you expect this to handle?

Probably this would best be done by modifying tests/java/org/python/jsr223/ScriptEngineTest.java

Thanks!

I will write some unit tests for this.

Sorry for the delay. My computer broke, so I can buy one for Christmas ;-(. Here's the complete diff

Accepted the patch for PyScriptEngine.java.  I had to alter some tests in ScriptEngineTest.java as compared to the .diff that was provided, but everything seems to work fine.  Patch changes have been committed.