Issue1760

classification
Title: logging library issue + monkey patch fix
Type: behaviour Severity: normal
Components: Library Versions: Jython 2.5
process
Status: open Resolution: remind
Dependencies: Superseder:
Assigned To: fwierzbicki Nosy List: fwierzbicki, yoav.aner
Priority: high Keywords:

Created on 2011-06-15.10:52:41 by yoav.aner, last changed 2014-05-22.00:29:18 by zyasoft.

Messages
msg6552 (view) Author: Yoav Aner (yoav.aner) Date: 2011-06-15.10:52:41
(copied from jython-dev mailing list, sorry if this is not the proper report format)

Hello,

First post to this list, so please excuse any mistakes or lack of knowledge.
I'm pretty new to jython (and perhaps not fully understand the relationship
with python etc).

One relatively small issue we've came up with is using the logging library.
Things are working fine, but when trying to add the method + line number of
the calling function to the log formatter
(e.g. %(filename)s:%(funcName)s(%(lineno)d ) then we always seemed to get
the line number of __init__.py of the logger itself...

Upon further investigation, it turned out it happens because __init__.py
only looks at .pyc and .pyo files, and ignores $py.class files. Specifically
these lines of code:

if hasattr(sys, 'frozen'): #support for py2exe
    _srcfile = "logging%s__init__%s" % (os.sep, __file__[-4:])
elif string.lower(__file__[-4:]) in ['.pyc', '.pyo']:
    _srcfile = __file__[:-4] + '.py'
else:
    _srcfile = __file__
_srcfile = os.path.normcase(_srcfile)


If another condition is added, e.g.

elif __file__.endswith('$py.class'):
    _srcfile = __file__[:-9] + '.py'

then it fixes the problem. Not sure if this needs to be reported upstream to
python or to the jython dev... Again apologies if this is the wrong place to
report this.

Cheers
Yoav
msg7737 (view) Author: Frank Wierzbicki (fwierzbicki) Date: 2013-02-25.18:34:01
This looks like a simple fix, setting to high to get my attention.
History
Date User Action Args
2014-05-22 00:29:18zyasoftsetresolution: remind
2013-02-25 18:34:01fwierzbickisetpriority: high
assignee: fwierzbicki
versions: + Jython 2.5, - 2.5.1
messages: + msg7737
nosy: + fwierzbicki
2011-06-15 10:52:41yoav.anercreate