Issue1779428

hi i have added one check  for infinite and resolve the issue now test_complex is running fine

Is the comparison of x to Double.NEGATIVE_INFINITY a typo? Shouldn't that be compared against z?:

                 z = Double.valueOf(string.substring(s, end)).doubleValue();
-                if (z == Double.POSITIVE_INFINITY || x == Double.NEGATIVE_INFINITY) {
-                       throw Py.ValueError("double() out of range:" + string);
+                if (z == Double.NEGATIVE_INFINITY || z == Double.POSITIVE_INFINITY) {
+                       throw Py.ValueError("float() out of range: " + string);
                 }

sourceforge kind of munged the diff I was trying to present to you, maybe this one will be easier to read:

 z = Double.valueOf(string.substring(s, end)).doubleValue();
-if (z == Double.POSITIVE_INFINITY || x == Double.NEGATIVE_INFINITY) {
-    throw Py.ValueError("double() out of range:" + string);
+if (z == Double.NEGATIVE_INFINITY || z == Double.POSITIVE_INFINITY) {
+    throw Py.ValueError("float() out of range: " + string);
 }
 
Also this patch contains a tab character. Could you please disable tabs in your editor for all future patches? The codebase prefers spaces, thanks!

actually, is the NEGATIVE_INFINITY check needed at all? seems like the way complex parses numbers, they might only be positive in this case, but I'm not totally sure about that

pjenvey :-

if we are checking with varible Z we need not to check with NEGATIVE_INFINITY 
it is needed only when we are checking with variable x 

i am attaching patch plz have a look on it..

File Added: bug_complex_range.diff

applied in r4312, thanks ukeshav!