Issue1800381
Created on 2007-09-22.22:42:34 by tristanlk, last changed 2007-09-25.16:38:59 by cgroves.
|
| File name |
Uploaded |
Description |
Edit |
Remove |
|
obj-unicode.patch
|
tristanlk,
2007-09-22.22:42:34
|
removes __unicode__ from object |
|
|
|
obj-unicode.patch
|
tristanlk,
2007-09-25.07:57:52
|
|
|
|
|
| msg2897 (view) |
Author: tristan (tristanlk) |
Date: 2007-09-22.22:42:34 |
|
here is my patch to remove object.__unicode__.
also when __unicode__ is called on object, it checks for the existance of a __unicode__ method, and calls it if it exists, rather than just calling __str__ everytime.
As far as i can tell this doesn't break anything, any my python code now runs as expected.
|
| msg2898 (view) |
Author: Philip Jenvey (pjenvey) |
Date: 2007-09-24.01:28:29 |
|
did you run the full regression test (and from the dist dir, not the Lib dir)? This can probably be removed -- it's just that it's so old, I don't think anyone knows for sure =]
|
| msg2899 (view) |
Author: Charlie Groves (cgroves) |
Date: 2007-09-25.04:29:21 |
|
Committed a slightly modified version of this patch to trunk in r3538. I didn't actually modify the __unicode__ method on PyObject since Java classes that extend it expect that functionality. I just removed the __unicode__ descriptor which means the method isn't visible from Python code and the test attached to the bug works as expected.
|
| msg2900 (view) |
Author: tristan (tristanlk) |
Date: 2007-09-25.07:57:52 |
|
there are still problems if the PyObject.__unicode__ function isn't modified.
here is a new patch with working changes (my old patch was broken)
File Added: obj-unicode.patch
|
| msg2901 (view) |
Author: Charlie Groves (cgroves) |
Date: 2007-09-25.16:38:59 |
|
Added code similar to the patch to look up __unicode__ on class objects in PyInstance where it should've been in r3542.
|
|
| Date |
User |
Action |
Args |
| 2007-09-22 22:42:34 | tristanlk | create | |
|
