Issue1840038

classification
Title: patch for PyUnicode (fixes [ 1782565 ])
Type: Severity: normal
Components: None Versions:
Milestone:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: pjenvey, tristanlk, zyasoft
Priority: normal Keywords: patch

Created on 2007-11-28.05:12:34 by tristanlk, last changed 2008-06-08.22:10:53 by pjenvey.

Files
File name Uploaded Description Edit Remove
pyunicode.patch tristanlk, 2007-11-28.05:50:38
Messages
msg2956 (view) Author: tristan (tristanlk) Date: 2007-11-28.05:12:34
I've just finished making this patch which removes some of the issues with PyUnicode behaving badly.
msg2957 (view) Author: tristan (tristanlk) Date: 2007-11-28.05:16:54
oops. just found a bug with this.
forgot about the "print b" use case.. will post again when i've fixed it
msg2958 (view) Author: tristan (tristanlk) Date: 2007-11-28.05:50:38
ok, fixed up print. hopefully nothing else is broken :)
File Added: pyunicode.patch
msg2959 (view) Author: tristan (tristanlk) Date: 2007-11-28.06:30:49
ok, i found another problem when calling b.encode().

i've solved it, and the print problem, simply by removing the toString() function from PyUnicodeDerived
is there any reason that this function needs to be in here and implemented as it is. i feel it's a bit silly to be calling __repr__ on derived objects, where the java toString is called on normal unicode objects.
msg2960 (view) Author: Jim Baker (zyasoft) Date: 2007-12-27.22:08:45
Tested, this resolves the following issue for me:
http://pylonshq.com/pasties/624

Rolling change into modern, for merge against trunk soon.
msg3254 (view) Author: Philip Jenvey (pjenvey) Date: 2008-06-08.22:10:53
This was merged back to trunk a while ago, closing out. thanks tristan
History
Date User Action Args
2008-06-08 22:10:53pjenveysetstatus: open -> closed
resolution: fixed
messages: + msg3254
nosy: + pjenvey
2007-11-28 05:12:34tristanlkcreate