Issue1872

Hi,
A shutil.Error occurs when using shutil.copytree on Windows 7 x64.
Here is a sample:

c:\Users\olivier>c:\sp\lib\python\jython-2.5.3b1-1.6\jython.bat
Jython 2.5.3b1 (2.5:5fa0a5810b25, Feb 22 2012, 12:39:02)
[Java HotSpot(TM) 64-Bit Server VM (Sun Microsystems Inc.)] on java1.6.0_31
Type "help", "copyright", "credits" or "license" for more information.
>>> import os, shutil
>>> os.mkdir("foo")
>>> open("foo/bar.txt", "w").close()
>>> shutil.copytree("foo", "foo2")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\sp\lib\python\jython-2.5.3b1-1.6\Lib\shutil.py", line 144, in copytree
    raise Error, errors
shutil.Error: ['foo', 'foo2', "[Errno 5] Input/output error: 'foo2'"]

Thanks1

I get the same error on Windows 2003.

But the copy is actually successful, in that

foo2/
foo2/bar.txt

Both exist after the failure.

Is that true for you as well?

yes, same here.

The shutil module that jython uses is copied from cpython, i.e. we don't have a specialised version of it for jython.

Interestingly, the following section appears in the copytree function

####

    try:
        copystat(src, dst)
    except OSError, why:
        if WindowsError is not None and isinstance(why, WindowsError):
            # Copying file access times may fail on Windows
            pass
        else:
            errors.extend((src, dst, str(why)))


###

And if I comment out those lines, the error no longer appears, i.e. the copytree works correctly, and no errors are reported.

So, now to decide what is the best fix for this.

I've confirmed that it is the attempt to update the atime and mtime that is the cause of the error. If I define the copystat function this way

def copystat(src, dst):
    """Copy all stat info (mode bits, atime and mtime) from src to dst"""
    st = os.stat(src)
    mode = stat.S_IMODE(st.st_mode)
#    if hasattr(os, 'utime'):
#        os.utime(dst, (st.st_atime, st.st_mtime))
    if hasattr(os, 'chmod'):
        os.chmod(dst, mode)

The error does not appear.

The version of JNR that we use has been updated on the default branch, i.e. the 2.7 branch.

http://hg.python.org/jython/rev/a6ff07bed361

I can no longer reproduce the error.

Please can the submitter try this against the head revision?

Just ran into this using virtualenv, which therefore isn't possible to use with Jython 2.5.3 on Windows.

Based on the discussion, apparently this is only an issue on 2.5 on Windows; it will require an update of JNR to support for 2.5.