Issue1936

I have exactly the same problem as http://bugs.jython.org/issue1639 (see also http://xwiki.475771.n2.nabble.com/Deploying-on-JBoss-5-td5390212.html) but on JBoss AS 7 (7.1.1Final to be precise).

This time the problem is that JBoss AS7 has introduced the "vfs" protocol (and no longer "vfszip"), thus the JAR is not considered standalone and thus libs in the standalone's Lib/ directory are not taken into account...

The URL I get is from getJarFileName() is:
vfs:/Users/vmassol/Desktop/jboss-as-7.1.1.Final/standalone/deployments/xwiki.war/WEB-INF/lib/jython-standalone-2.5.2.jar/org/python/core/PySystemState.class

For details, see http://jira.xwiki.org/browse/XWIKI-7984

Thanks a lot. Would be awesome if this could make it in 2.5.3 :)

If I'm following correctly it looks like http://bugs.jython.org/issue1639 was applied before beta2 came out - do you still see an issue on beta2? If not do you have a suggested fix?

http://bugs.jython.org/issue1639 was in 2.5.2-rc1 (according to release notes on http://www.jython.org/latest.html).

I'm running 2.5.2 final. But this is not the same issue1639; it's similar to different. In issue 1639 the fix was to add support for the "vfszip" protocol. This issue is about also adding support for the "vfs" protocol which is in use in JBoss AS7. The fix is the same though; except checking for "vfs:" instead of "vfszip:".

Thanks

It sounds like a pretty trivial patch, but someone would need to make sure both "vfszip" and "vfs" will work. I don't have time before 2.5.3beta to look at this myself (since it would involve setting up JBoss instances etc for testing) but I'd be very willing to review a patch that did the same. I'll add Otmar to the nosy list to see if he has input since he accepted the other patch.

Here is a proposition of patch based on the implementation done for vfszip. Tested (only) with JBoss AS 7.1.1.Final on Ubuntu12.04.

Guys, any news on this. I'd really love to have this fixed. I see olivierH added a patch. Is there a binary somewhere that I could use to test it (if that's what's holding the closing of the issue)?

Thanks a lot

Vincent: If you can verify that olivierH's patch fixes things for you, I'll be happy to apply it.

olivierH: Do you want me to include your full name in the commit message or should I just go with "olivierH"? The patch is small enough that I won't need to bug you about a contributor agreement - though if you wouldn't mind signing one I'll point you to the instructions.

Frank: you can use my full name. I will be happy to sign a contributor 
agreement if it can make your work easier.

Olivier Heurtier: cool, I'll plan to use your full name when Vincent verifies the fix. The instructions for signing a contributor agreement are here: http://www.python.org/psf/contrib/ - and the right form is here: http://www.python.org/psf/contrib/contrib-form/ Note that they want a bugs.python.org username and not a bugs.jython.org one ("p" instead of "j")

I have signed and sent the contributor agreement today.

Olivier: great! Now if we can just get Vincent to confirm that his issue is fixed. Vincent?

Is there a binary I can get to retest?

Fixed in http://hg.python.org/jython/rev/df829bcbd4f3
Thanks Olivier Heurtier!

Vincent: the fix will be in 2.5.4rc1 and 2.7beta1 which I expect to get out this week. Let me know how it goes! I won't close the bug until you confirm that it is fixed.

Great. I'll retest when 2.5.4rc1 or 2.7beta1 are out, thanks.

Seems like 2.5.4RC1 fixed the issue! See http://jira.xwiki.org/browse/XWIKI-8812

Thanks a lot :)

Vincent: that's great! I'll go ahead and close this now. Thanks again for the patch Olivier!