Issue2077

marshal.dump(s) doesn't raise the appropriate ValueError when asked to marshal an unmarshalable object. Rather, it returns the string "?".

Observed behavior in Jython 2.7-b1:

>>> import marshal
>>> class Test(object): pass
...
>>> marshal.dumps(Test())
'?'
>>>


Expected behavior as shown by CPython 2.7:

>>> import marshal
>>> class Test(object): pass
...
>>> marshal.dumps(Test())
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: unmarshallable object
>>>

Patch attached.

Target beta 4

Thanks Andrew. I don't know why it took us so long to apply this simple patch.

Now in codebase at: https://hg.python.org/jython/rev/f5dda19d78c9

My attempt to find a complementary failing test ... er ... failed. In updating test_marshal from lib-python I just found three other things to fix, including #2744. Paradoxically, when those *are* fixed, the test does finally exercise the code Andrew added (in test_marshal.BugsTestCase.test_exact_type_match).