Issue2160

The function cmath.polar(x) returns a tuple (r, phi) where r should be the absolute value of x: r = abs(x). For instance, "polar(3+4j)" should return (5.0, 0.927) but Jython 2.7's value is (7.0, 0.927) instead.

This could be fixed by changing the way "r" is computed inside the "polar"-function in "cmath.java" to:

    public static PyTuple polar(PyObject in) {
        PyComplex z = complexFromPyObject(in);
        double phi = Math.atan2(z.imag, z.real);
        double r = Math.sqrt(z.real*z.real + z.imag*z.imag);  // <- Changed
        return new PyTuple(new PyFloat(r), new PyFloat(phi));
    }

Target beta 4, should be straightforward per the patch posted

This is tested by test_cmath, once we unskip. Thanks again for the patch - it solves a lot of failures in that test. (Unfortunately the test is too opaque in terms of how it's constructed, so I just got to it now as I picked it apart.)

Will be in trunk shortly.

Fixed in a recent commit - there's been a lot of recent attention on complex math