Issue2185

classification
Title: expatreader.py not included in Jython
Type: Severity: normal
Components: Library Versions: Jython 2.7, Jython 2.5
Milestone: Jython 2.7.2
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: fwierzbicki, zyasoft
Priority: high Keywords:

Created on 2014-08-04.02:23:42 by fwierzbicki, last changed 2015-12-29.23:48:01 by zyasoft.

Messages
msg8900 (view) Author: Frank Wierzbicki (fwierzbicki) Date: 2014-08-04.02:23:41
It looks like we should keep a copy of expatreader.py for Jython, removing the code at the top:

if sys.platform[:4] == "java":
    raise SAXReaderNotAvailable("expat not available in Java", None)

Since we do have a good part of expat support now.
msg8901 (view) Author: Frank Wierzbicki (fwierzbicki) Date: 2014-08-04.02:26:23
Note that this causes problems for Django which needs expatreader in manage.py
msg8902 (view) Author: Frank Wierzbicki (fwierzbicki) Date: 2014-08-04.02:31:22
See https://github.com/django/django/commit/d19a27066b2247102e65412aa66917aff0091112 to look at Django's use.
msg8903 (view) Author: Frank Wierzbicki (fwierzbicki) Date: 2014-08-04.02:38:15
Hopefully we can also update to a newer version of test_sax with this.
msg9019 (view) Author: Jim Baker (zyasoft) Date: 2014-09-24.03:14:50
Removing our modified version of test_sax works, so I did do that (https://hg.python.org/jython/rev/0fdc65448925). However, I was not able to get all the tests working in test_pyexpat with the change suggested by Frank:

test_ordered_attributes (__main__.SetAttributeTest) ... ERROR
test_returns_unicode (__main__.SetAttributeTest) ... ok
test_specified_attributes (__main__.SetAttributeTest) ... ERROR
test_parse_file (__main__.ParseTest) ... ERROR
test_unicode (__main__.ParseTest) ... ERROR
test_utf8 (__main__.ParseTest) ... ERROR
test_illegal (__main__.NamespaceSeparatorTest) ... ok
test_legal (__main__.NamespaceSeparatorTest) ... ok
test_zero_length (__main__.NamespaceSeparatorTest) ... ok
test (__main__.InterningTest) ... ok
test1 (__main__.BufferTextTest) ... FAIL
test2 (__main__.BufferTextTest) ... FAIL
test3 (__main__.BufferTextTest) ... ok
test4 (__main__.BufferTextTest) ... ok
test5 (__main__.BufferTextTest) ... ok
test6 (__main__.BufferTextTest) ... ok
test7 (__main__.BufferTextTest) ... ok
test_buffering_enabled (__main__.BufferTextTest) ... FAIL
test_default_to_disabled (__main__.BufferTextTest) ... FAIL
test (__main__.HandlerExceptionTest) ... ok
test (__main__.PositionTest) ... ERROR
test_parse_only_xml_data (__main__.sf1296433Test) ... FAIL
test_1000_bytes (__main__.ChardataBufferTest) ... ERROR
test_1025_bytes (__main__.ChardataBufferTest) ... ERROR
test_change_size_1 (__main__.ChardataBufferTest) ... ERROR
test_change_size_2 (__main__.ChardataBufferTest) ... ERROR
test_disabling_buffer (__main__.ChardataBufferTest) ... ERROR
test_unchanged_size (__main__.ChardataBufferTest) ... ERROR
test_wrong_size (__main__.ChardataBufferTest) ... ERROR
test1 (__main__.MalformedInputText) ... FAIL
test2 (__main__.MalformedInputText) ... FAIL
test_ignore_use_foreign_dtd (__main__.ForeignDTDTests) ... ERROR
test_use_foreign_dtd (__main__.ForeignDTDTests) ... ERROR

This may still suffice for Django however.
msg9020 (view) Author: Jim Baker (zyasoft) Date: 2014-09-24.03:15:16
Target beta 4
History
Date User Action Args
2015-12-29 23:48:01zyasoftsetmilestone: Jython 2.7.1 -> Jython 2.7.2
2015-04-20 20:56:04zyasoftsetmilestone: Jython 2.7.1
2014-09-24 03:15:17zyasoftsetmessages: + msg9020
2014-09-24 03:14:51zyasoftsetnosy: + zyasoft
messages: + msg9019
2014-08-04 02:38:15fwierzbickisetmessages: + msg8903
2014-08-04 02:31:22fwierzbickisetmessages: + msg8902
2014-08-04 02:27:04fwierzbickisetpriority: high
2014-08-04 02:26:24fwierzbickisetmessages: + msg8901
2014-08-04 02:23:42fwierzbickicreate