Issue2330

classification
Title: full-build fails to copy CPython License
Type: behaviour Severity: minor
Components: Installer Versions: Jython 2.7
Milestone:
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: fwierzbicki, jeff.allen, kprussing, zyasoft
Priority: normal Keywords: patch

Created on 2015-04-15.15:37:06 by kprussing, last changed 2018-03-22.08:13:10 by jeff.allen.

Files
File name Uploaded Description Edit Remove
full-build.patch kprussing, 2015-04-15.15:37:05
Messages
msg9859 (view) Author: Keith Prussing (kprussing) Date: 2015-04-15.15:37:05
The full-build target fails when copying the LICENSE file from the CPython repository to dist/LICENSE_CPython.txt.  Line 744 of build.xml has the license path set to ${checkout.dir}/python/LICENSE; however, this repository is never cloned.  The attached patch adds the hg call to clone the CPython repository into the correct location in the checkout target.

Error:

<snip>
copy-license:
     [echo] copy CPython LICENSE from .../jython/../full_build/work/checkout/python

BUILD FAILED
.../jython/build.xml:744: Warning: Could not find file .../jython/../full_build/work/checkout/python/LICENSE to copy.

Expected Result: The installer would be built.

Cause: .../jython/full_build/work/checkout/python does not exist.
msg9925 (view) Author: Jim Baker (zyasoft) Date: 2015-04-23.03:51:17
I suppose, but I really don't see the necessity of this. Jython and CPython are both under the PSF, and LICENSE.txt clearly indicates the licensing. So this is cleanup at most.

We probably should make the inclusion of the core (CPython) standard library explicit in ACKNOWLEDGMENTS, much as we do with other libraries.
msg9929 (view) Author: Jim Baker (zyasoft) Date: 2015-04-23.13:42:08
Frank, so presumably adding one text file is a safe change ;), so can you apply Keith's patch for final? I will write a change in ACKNOWLEDGMENTS re CPython. Otherwise we should assume for the moment that nothing else is changing in the final release.
msg9930 (view) Author: Jim Baker (zyasoft) Date: 2015-04-23.13:52:45
ACKNOWLEDGMENTS changed in https://hg.python.org/jython/rev/cb13feb73a05: "Sibling relationship with CPython includes use and derivation"
msg11711 (view) Author: Jeff Allen (jeff.allen) Date: 2018-02-25.13:15:38
What's the status of this?

We've made a change that acknowledges the CPython licence, but not the patch that checks out the whole of CPython in order to get a copy. (Good, I think)

The full-build doesn't work for me (fails on informix jar not present), but then I don't understand its objective or prerequisites. I've never had trouble checking out or building.

Close?
History
Date User Action Args
2018-03-22 08:13:10jeff.allensetpriority: normal
milestone: Jython 2.7.0 ->
2018-02-25 13:15:38jeff.allensetnosy: + jeff.allen
messages: + msg11711
2015-04-23 13:52:45zyasoftsetmessages: + msg9930
2015-04-23 13:42:08zyasoftsetnosy: + fwierzbicki
messages: + msg9929
milestone: Jython 2.7.0
2015-04-23 03:51:18zyasoftsetnosy: + zyasoft
messages: + msg9925
2015-04-15 15:37:06kprussingcreate