Issue2646

https://travis-ci.org/jythontools/jython/jobs/305970286#L1066

Think this one looks like a unicode issue. Interestingly I don't see it on my machine?

Offending result for reference:

test_os_jy

     [exec] bash: warning: setlocale: LC_ALL: cannot change locale (tr_TR.UTF-8)
     [exec] bash: warning: setlocale: LC_ALL: cannot change locale (tr_TR.UTF-8)
     [exec] test test_os_jy failed -- Traceback (most recent call last):
     [exec]   File "/home/travis/build/jythontools/jython/dist/Lib/test/test_os_jy.py", line 243, in test_getcwd
     [exec]     self.assertEqual(p.stdout.read().decode("utf-8"), temp_cwd)
     [exec] AssertionError: u'/home/travis/build/jythontools/jython/tempcwd-\xe4\xb8\xad\xe6\x96\x87' != '/home/travis/build/jythontools/jython/tempcwd-\xe4\xb8\xad\xe6\x96\x87'

But those two strings aren't equal, and Jython knows it now because I just fixed unicode-str comparison in #2638. It looks like it is coming from a test using spawned subprocesses. subprocess has a different implementation on Windows (me) and Unix (Travis), or maybe the test is skipped on Windows.

Anyway, I think investigation will show that the test is at fault. (Looks like a bit I touched in the file name encoding change.)

Grrr. Another failure I missed because we suppress test_os_jy from the regrtest on Windows. The previous definition of str-unicode equality let this bit of double-think slip through.

We only do this because the locale tests fail for Cygwin. I'll re-enable it and Cygwin users will just have to put up with that. Unless anyone can tell me quickly how to skipIf(is_cygwin)?

Fixed at https://hg.python.org/jython/rev/320911f1aeba, and the test enabled for Windows.