Message11989

Author	stefan.richthofer
Recipients	jamesmudd, jeff.allen, stefan.richthofer
Date	2018-05-17.19:11:27
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1526584287.83.0.682650639539.issue2672@psf.upfronthosting.co.za>
In-reply-to

Content
I thought about it and would slightly prefer the second version. - it is still more efficient - it somewhat clearly documents the nature of an edge case Your PR looks good, especially thanks for writing a test! If you don't mind I would just switch the one-liner to the second version on merging. So you won't have to do anything. Is that okay?

I thought about it and would slightly prefer the second version.
- it is still more efficient
- it somewhat clearly documents the nature of an edge case

Your PR looks good, especially thanks for writing a test!
If you don't mind I would just switch the one-liner to the second version on merging. So you won't have to do anything.
Is that okay?

History
Date	User	Action	Args
2018-05-17 19:11:27	stefan.richthofer	set	messageid: <1526584287.83.0.682650639539.issue2672@psf.upfronthosting.co.za>
2018-05-17 19:11:27	stefan.richthofer	set	recipients: + stefan.richthofer, jeff.allen, jamesmudd
2018-05-17 19:11:27	stefan.richthofer	link	issue2672 messages
2018-05-17 19:11:27	stefan.richthofer	create