Message12035

Author stefan.richthofer
Recipients jamesmudd, jeff.allen, stefan.richthofer
Date 2018-06-30.12:24:16
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1530361457.53.0.56676864532.issue2672@psf.upfronthosting.co.za>
In-reply-to
Content
I looked at the new version. There might be a configuration where the call to positiveSign actually does something, which might result now in something like +-2147483648. The version I suggested earlier, i.e.
number = value == Integer.MIN_VALUE ? "2147483648" : Integer.toString(-value);
appears safer to me (and more explicit).

> I guess looking up a function in the globals is faster in Jython for what that's worth.
I'm convinced that Jython can be potentially faster than CPython, obviously because of the JIT. It's a question of identifying the performance flaws in the current impementation.
History
Date User Action Args
2018-06-30 12:24:17stefan.richthofersetmessageid: <1530361457.53.0.56676864532.issue2672@psf.upfronthosting.co.za>
2018-06-30 12:24:17stefan.richthofersetrecipients: + stefan.richthofer, jeff.allen, jamesmudd
2018-06-30 12:24:17stefan.richthoferlinkissue2672 messages
2018-06-30 12:24:16stefan.richthofercreate