Message4954

Author pjenvey
Recipients fwierzbicki, pjenvey, thatmattbone
Date 2009-07-28.05:58:20
SpamBayes Score 1.7046582e-07
Marked as misclassified No
Message-id <1248760702.25.0.644236896665.issue1336@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for this, a couple things:

no tabs, just 4 space indents

pyget looks like cut and paste of getNode, I think they need 
refactoring..

Actually I think getNode is probably unnecessary if we have a working 
pyget. Then the PySequence __get/set/delitem__ methods can do all the 
work for us and we wouldn't have to override them to use getNode.

Those PySequence methods should also do the work of the first few lines 
of getNode for us (the adjusting of the index and throwing an IndexError 
if it's invalid) via PySequence.delegator
History
Date User Action Args
2009-07-28 05:58:22pjenveysetmessageid: <1248760702.25.0.644236896665.issue1336@psf.upfronthosting.co.za>
2009-07-28 05:58:22pjenveysetrecipients: + pjenvey, fwierzbicki, thatmattbone
2009-07-28 05:58:21pjenveylinkissue1336 messages
2009-07-28 05:58:20pjenveycreate