Message6058

Author	zyasoft
Recipients	MrMeanie, adam.spiers, amak, colinhevans, fwierzbicki, matt_brinkley, pjenvey, zyasoft
Date	2010-09-09.15:45:09
SpamBayes Score	0.011599254
Marked as misclassified	No
Message-id	<1284047110.04.0.983106724223.issue1327@psf.upfronthosting.co.za>
In-reply-to

Content
Geoffrey, I think the issue here is that we have a bad implementation of double-checked locking. The aspect of how it interacts with thread locals makes it subtle, so I'm going to make the whole lookup synchronized. In general, we usually pass the ThreadState in our code, but this could be a performance bottleneck especially at callbacks from Java. Let's worry about that later, correctness first.

Geoffrey, I think the issue here is that we have a bad implementation of double-checked locking. The aspect of how it interacts with thread locals makes it subtle, so I'm going to make the whole lookup synchronized.

In general, we usually pass the ThreadState in our code, but this could be a performance bottleneck especially at callbacks from Java. Let's worry about that later, correctness first.

History
Date	User	Action	Args
2010-09-09 15:45:10	zyasoft	set	messageid: <1284047110.04.0.983106724223.issue1327@psf.upfronthosting.co.za>
2010-09-09 15:45:10	zyasoft	set	recipients: + zyasoft, fwierzbicki, amak, pjenvey, colinhevans, MrMeanie, matt_brinkley, adam.spiers
2010-09-09 15:45:09	zyasoft	link	issue1327 messages
2010-09-09 15:45:09	zyasoft	create