Message7231

> Hi Jez Ng! Have you signed a PSF contributor agreement?

Not yet. I'll get it done on Monday -- don't have access to a printer over the weekend. I'm not a Mozilla employee, though I did intern there last summer.

> You probably don't want to convert via __tojava__(String.class). ArgParser can return you a String in a nicer fashion,

I'm not sure if I misread the code, but it looks like ArgParser checks that the arguments correspond to a whitelist of keyword arguments. Is there a way to make it accept an arbitrary number of such arguments?

> You should re-enable the attrgetter test too along w/ its fix

Oops, the attrgetter code shouldn't have been included in this patch... that code was carried over from the patch to issue 1909. I'm generally a git user, and hg confused me.

> BTW I should have started with a "Thanks for this!" as Philip did before launching into annoying legal stuff, so sorry about that :)

No problem at all. Thanks for the quick patch review!