Message7866

Author amak
Recipients amak, dchrome, fwierzbicki, jeff.allen
Date 2013-02-28.10:25:58
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1362047158.47.0.0873916583201.issue2014@psf.upfronthosting.co.za>
In-reply-to
Content
phinx should not be checking raw error numbers, i.e. error 0 and 17, since these values are platform specific. This is a common problem with cpython code. Instead the code should be checking for the symbolic constants in errno, not the raw numbers. (On jython, these numbers will often be different between platforms, just as they are between cpython on *nix and cpython in windows)

I can see that this has been a problem with sphinx before.

http://stackoverflow.com/questions/1085791/does-sphinx-run-on-jython

Which resulted in this bug report

https://bitbucket.org/birkenfeld/sphinx/issue/265/sphinx-doesnt-run-with-jython251

Which resulted in this code patch, which did not properly fix the problem.

https://bitbucket.org/birkenfeld/sphinx/commits/6948941768d2

I think this should be reported to the sphinx people, with a request that they use symbolic constants for errors, not platform-specific integers.
History
Date User Action Args
2013-02-28 10:25:58amaksetmessageid: <1362047158.47.0.0873916583201.issue2014@psf.upfronthosting.co.za>
2013-02-28 10:25:58amaksetrecipients: + amak, fwierzbicki, jeff.allen, dchrome
2013-02-28 10:25:58amaklinkissue2014 messages
2013-02-28 10:25:58amakcreate