Message9114

Author	zyasoft
Recipients	kmuehlbr, zyasoft
Date	2014-10-06.16:42:56
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1412613777.15.0.566573802596.issue2163@psf.upfronthosting.co.za>
In-reply-to

Content
In general, PySystemState#initStaticFields is problematic code. Also, it's not clear to me that most of these fields needs to be mutable vs final. Example: even if the Python semantics do allow True to be set to some other value, it's not really Py.True that's changing, it's instead changes in the entries in __builtin__.__dict__ (see __builtin__#fillWithBuiltins) This is just the sort of refactoring we would like to do before the final beta, which should be beta 4

In general, PySystemState#initStaticFields is problematic code.

Also, it's not clear to me that most of these fields needs to be mutable vs final. Example: even if the Python semantics do allow True to be set to some other value, it's not really Py.True that's changing, it's instead changes in the entries in __builtin__.__dict__ (see __builtin__#fillWithBuiltins)

This is just the sort of refactoring we would like to do before the final beta, which should be beta 4

History
Date	User	Action	Args
2014-10-06 16:42:57	zyasoft	set	messageid: <1412613777.15.0.566573802596.issue2163@psf.upfronthosting.co.za>
2014-10-06 16:42:57	zyasoft	set	recipients: + zyasoft, kmuehlbr
2014-10-06 16:42:57	zyasoft	link	issue2163 messages
2014-10-06 16:42:56	zyasoft	create