Message9795

Author	zyasoft
Recipients	kevinmcmurtrie, zyasoft
Date	2015-04-11.03:09:26
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1428721767.46.0.475700529755.issue2321@psf.upfronthosting.co.za>
In-reply-to

Content
Agreed, it's overzealous. The problem here is that it should be private static final Map<Thread, ThreadState> cachedThreadState = new MapMaker().weakKeys().makeMap(); (so not weakValues()) We still want ThreadState to GC upon the corresponding Thread be GC'ed, so weakKeys() makes sense.

Agreed, it's overzealous. The problem here is that it should be 

    private static final Map<Thread, ThreadState> cachedThreadState =
        new MapMaker().weakKeys().makeMap();

(so not weakValues())

We still want ThreadState to GC upon the corresponding Thread be GC'ed, so weakKeys() makes sense.

History
Date	User	Action	Args
2015-04-11 03:09:27	zyasoft	set	messageid: <1428721767.46.0.475700529755.issue2321@psf.upfronthosting.co.za>
2015-04-11 03:09:27	zyasoft	set	recipients: + zyasoft, kevinmcmurtrie
2015-04-11 03:09:27	zyasoft	link	issue2321 messages
2015-04-11 03:09:26	zyasoft	create