Issue1218010

classification
Title: build.xml and the javac source parameter
Type: Severity: normal
Components: None Versions:
Milestone:
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: johahn
Priority: normal Keywords: patch

Created on 2005-06-10.07:56:18 by johahn, last changed 2005-06-16.08:26:47 by johahn.

Files
File name Uploaded Description Edit Remove
ant.jikes.patch johahn, 2005-06-16.08:26:47 fixes some minor issues I have with build.xml and .cvsignore
Messages
msg2448 (view) Author: Johan M. Hahn (johahn) Date: 2005-06-10.07:56:18
I ran into a small problem when running the ant script 
under java 1.5. Specifying target to 1.1 with javac 1.5 
without also specifying a source code format is an error. 
This is because the source parameter defaults to 1.5 
which requires that the target is also set to 1.5. The ant 
docs recommends that you always specify both the 
source and target attributes anyway, to avoid java 
version dependent defaults. This patch adds the source 
attribute to all javac and javadoc elements. The value is 
set to 1.2.
msg2449 (view) Author: Johan M. Hahn (johahn) Date: 2005-06-13.08:57:19
Logged In: YES 
user_id=887415

jdk.source.version should be set to 1.3 instead of 1.2 to be
absolutely correct. I don't know if 1.2 even exists (though
it did have the intended effect). In Eclipse you can only
choose between 1.3 and 1.4 when target is 1.2.
msg2450 (view) Author: Johan M. Hahn (johahn) Date: 2005-06-16.08:26:47
Logged In: YES 
user_id=887415

1) I've uploaded an updated version of this patch. It is now
also explicit about the javac nowarn attribute, needed when
building with the jikes compiler, as it produces many
warnings. It defaults to false.

2) Another thing I've had problems with stems from Eclipse
using the same output directory for the jython files as well
as the bugtests. It means that the build directory will
contain many .class files. Not all of them should be put
into jython.jar as is done now. Instead of...
          <include name="**/*.class" />
          <include name="**/ucnhash.dat" />
          <include name="**/*.properties" />

... I suggest something like...
          <include name="com/**/*" />
          <include name="org/**/*" />
          <include name="jxxload_help/*" />
          <include name="javatests/*" />

3) I've also removed the deprecation flag from beeing
reported in the jar manifest since it has no meaning after
the build is done.

4) Added ant.properties to .cvsignore.
History
Date User Action Args
2005-06-10 07:56:18johahncreate