Issue1505666
Created on 2006-06-13.21:18:26 by juneau001, last changed 2006-08-13.02:51:20 by cgroves.
File name |
Uploaded |
Description |
Edit |
Remove |
PyInstance.java
|
juneau001,
2006-06-13.21:18:27
|
PyInstance.java source - Repairs Bug #738951 |
|
|
msg2502 (view) |
Author: Juneau001 (juneau001) |
Date: 2006-06-13.21:18:26 |
|
I was able to repair this slice anomaly by altering
the PyInstance class.
I made the following repairs:
Line 600: Added within the catch block:
return invoke("__getitem__", key);
Line 618: Added the try/catch block:
try {
PyObject ret = trySlice
(key, "__getslice__", null);
if (ret != null)
return ret;
} catch (PyException e){
return invoke("__getitem__", key);
}
When __getattr__('__getslice__') raises ANY error,
__getitem__ is invoked as requested.
|
msg2503 (view) |
Author: Charlie Groves (cgroves) |
Date: 2006-08-13.02:51:20 |
|
Logged In: YES
user_id=1174327
Applied in r2888.
If you send in any more patches Josh(which are most welcome)
they should be diffs and not whole source files. You can
make one like 'svn diff PyInstance.java >
738951_slice_fix.diff'. Not such a big deal for a single
file, but if you've changed multiple things it makes it much
easier for me and keeps you from having to make a line by
line description of what you did.
I'd also like to point out that Jython Slice Anomaly
wouldn't be a horrible name for a band.
|
|
Date |
User |
Action |
Args |
2006-06-13 21:18:26 | juneau001 | create | |
|