Issue1515

classification
Title: modjy sometimes adds None to the sys.path
Type: Severity: normal
Components: Library Versions: 2.5.1
Milestone:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: amak Nosy List: amak, crankycoder
Priority: Keywords:

Created on 2009-12-04.20:24:16 by crankycoder, last changed 2009-12-14.15:51:58 by amak.

Messages
msg5349 (view) Author: Victor Ng (crankycoder) Date: 2009-12-04.20:24:16
modjy append None to sys.path causing all kinds of badness if
app_directory is not set and it can't be resolved by using getRealPath.
 Servlets sometimes return NULL for getRealPath.  In that case - don't
touch sys.path
msg5350 (view) Author: Victor Ng (crankycoder) Date: 2009-12-04.20:25:24
bug tracker won't let me attach a patch
---

37c37
<         if not self.app_directory in sys.path:
---
>         if self.app_directory and not self.app_directory in sys.path:
msg5351 (view) Author: Victor Ng (crankycoder) Date: 2009-12-04.20:34:58
sorry - that patch should be applied to lib/modjy/modjy_publish.py
msg5379 (view) Author: Alan Kennedy (amak) Date: 2009-12-14.15:17:05
Looking at this now.
msg5380 (view) Author: Alan Kennedy (amak) Date: 2009-12-14.15:51:58
Fixed at revision 6957.

Thanks Victor, for the report and the patch.
History
Date User Action Args
2009-12-14 15:51:58amaksetstatus: open -> closed
resolution: fixed
messages: + msg5380
2009-12-14 15:17:05amaksetassignee: amak
messages: + msg5379
components: + Library, - Core
nosy: + amak
2009-12-04 20:34:58crankycodersetmessages: + msg5351
2009-12-04 20:25:24crankycodersetmessages: + msg5350
2009-12-04 20:24:16crankycodercreate