Issue1541

This serves as a placeholder for the patch suggested by Steve Yegge (http://sourceforge.net/mailarchive/forum.php?thread_name=9c768dc61001121642t5bd1a7ddmd1fe9e088e1d9ab0%40mail.gmail.com&forum_name=jython-dev)

This is the comment from Steve Yegge:

The attached patchfile is a zip of 2 files:  modified files and new files.  To apply it:
  - unzip google-indexer.zip into .../jython (parent of src/ directory)
  - tar zxf google-indexer-newfiles.tar.gz
  - patch -p0 < google-indexer-patch.diff

You can run the unit tests with "ant idxtest".  Instructions for running the demo app are in the doc header of src/org/python/indexer/demos/HtmlDemo.java.

now trying to get rid of the compile errors, and running the tests

There are some java-6-isms in the provided patch

replacing String.isEmpty() by String.length() == 0 in:
- Indexer.java
- Util.java

replacing new String(byte[], Charset) with new String(byte[], String) in Util.java

removing the @Override annotation from method compareTo() in class StyleApplier.Tag

rolled back the change in .classpath, because our eclipse workspace currently needs a separate entry for the ant libraries

rolled back the addition of antlr-runtime-3.1.3.jar to main.classpath in build.xml, because the following ant targets run fine without it:
 - developer-build
 - idxtest
 - javatest


running target idxtest I get:

idxtest:
    [junit] Running org.python.indexer.IndexerTest
    [junit] Tests run: 77, Failures: 0, Errors: 0, Time elapsed: 3.246 sec
    [junit] Running org.python.indexer.TestBase
    [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 0.662 sec
BUILD SUCCESSFUL


running javatest I get:
javatest:
    :
    [junit] Running org.python.indexer.IndexerTest
    [junit] Tests run: 77, Failures: 0, Errors: 0, Time elapsed: 3.125 sec
    [junit] Running org.python.indexer.TestBase
    [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 0.667 sec
    :
BUILD SUCCESSFUL

removed warnings, such as:
 - unread fields
 - invalid javadoc references
 - missing @Override annotations
 - @SuppressWarnings("hiding")
 - @SuppressWarnings("synthetic-access")
 - @SuppressWarnings("unused")
 - @SuppressWarnings("unchecked")

idxtest OK (subset of javatest)
javatest OK
regrtest OK
launchertest OK
no new bugtest failures introduced

running
  org.python.indexer.demos.HtmlDemo ${workspace_loc}/jython-trunk/CPythonLib/email/ 
leads to the following console output:

building index...
init: Bootstrap types weren't encountered in bootstrapping: [class org.python.core.PyBuiltinCallable, class org.python.core.PyObject, class org.python.core.PyDataDescr, class org.python.core.PyType]
Summary: 
- modules loaded: 29
- unresolved modules: 16
base64: /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/encoders.py, /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/test/test_email.py, /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/test/test_email_renamed.py, /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/utils.py
difflib: /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/test/test_email.py, /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/test/test_email_renamed.py
email: /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/__init__.py and 23 more
imghdr: /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/mime/image.py
quopri: /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/encoders.py, /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/utils.py
random: /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/generator.py, /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/utils.py
re: /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/base64mime.py and 7 more
sndhdr: /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/mime/audio.py
socket: /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/utils.py
string: /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/quoprimime.py
test: /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/test/test_email.py, /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/test/test_email_codecs.py, /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/test/test_email_codecs_renamed.py, /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/test/test_email_renamed.py, /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/test/test_email_torture.py
types: /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/test/test_email_torture.py
unittest: /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/test/test_email.py, /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/test/test_email_codecs.py, /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/test/test_email_codecs_renamed.py, /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/test/test_email_renamed.py, /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/test/test_email_torture.py
urllib: /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/utils.py
uu: /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/message.py
warnings: /Users/oti/stuff/workspace/jython/jython-trunk/CPythonLib/email/generator.py and 6 more

semantics problems: 25
parsing problems: 0
generating html...
wrote 29 files to /Users/oti/stuff/workspace/jython/jython-trunk/./html

initially checked in, revision 6990

this is now on trunk (revision 6990), so this can be closed IMHO.