Issue1612711

classification
Title: Bug [ 1604265 ] PyStringMap doesn't have iter
Type: Severity: normal
Components: None Versions:
Milestone:
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: h_eriksson, kzuberi
Priority: normal Keywords: patch

Created on 2006-12-10.18:42:07 by h_eriksson, last changed 2006-12-14.05:29:39 by kzuberi.

Files
File name Uploaded Description Edit Remove
Bug1604265.patch h_eriksson, 2006-12-10.18:42:07
Messages
msg2566 (view) Author: Henrik Eriksson (h_eriksson) Date: 2006-12-10.18:42:07
Bugfix for [ 1604265 ] PyStringMap doesn't have iter<keys,values,items>
msg2567 (view) Author: Khalid Zuberi (kzuberi) Date: 2006-12-13.22:46:01

The patch applies and builds cleanly, follows the implementation in PyDictionary. The dict-proxy tests in test_descr now fail for a different reason, because of missing __weakref__ and __doc__ attributes. Didn't notice any new failures in regrtest or bugtests. 

Looks okay to me. Thanks for contributing the fix! Will commit shortly, assuming no other issues raised.

- kz

- kz
msg2568 (view) Author: Khalid Zuberi (kzuberi) Date: 2006-12-14.05:29:39

Applied to trunk in r3022.

- kz
History
Date User Action Args
2006-12-10 18:42:07h_erikssoncreate