Issue1626844
Created on 2007-01-03.11:48:50 by lmoore, last changed 2008-09-14.06:52:40 by zyasoft.
|
| File name |
Uploaded |
Description |
Edit |
Remove |
|
binascii.patch
|
lmoore,
2007-01-03.11:48:50
|
fixes for binascii |
|
|
|
| msg2576 (view) |
Author: lantz moore (lmoore) |
Date: 2007-01-03.11:48:50 |
|
made Error and Incomplete classes.
fixed some boundary conditions for the uu methods.
implemented the qp methods.
|
| msg2577 (view) |
Author: Khalid Zuberi (kzuberi) |
Date: 2007-01-10.08:34:29 |
|
I believe 2.2 could use a2b_qp & friends too, an implementation that didn't depend on java.util.regex would be suitable to both. Guess i just worry too much about 2.2 ;-). Oh well, it'll just have to do without then, regex is fine for 2.3 as far as i know.
Thanks for the patch. If anyone else has a bit of time for review that'd be great, otherwise i'll get back to it in a bit.
- kz
|
| msg2578 (view) |
Author: Charlie Groves (cgroves) |
Date: 2007-01-20.17:29:59 |
|
java.util.regex is fine for 2.3.
|
| msg2579 (view) |
Author: Khalid Zuberi (kzuberi) |
Date: 2007-05-04.07:42:39 |
|
Couple comments: seems to me Error & Incomplete should have a base of Exception not RuntimeError (just comparing cpython), and the arg handling for eg header in a2b_qp will give a ClassCastException if the arg isn't an int.
Now that regex is okay for 2.2, i might be able to fixup & commit this in time to land in the next beta, which will probably be cut any time now ...
- kz
|
| msg2580 (view) |
Author: Charlie Groves (cgroves) |
Date: 2007-05-04.21:49:45 |
|
I'm planning on closing out the last couple beta2 items tomorrow and cutting it over to a tag on Sunday night.
|
| msg2581 (view) |
Author: Khalid Zuberi (kzuberi) |
Date: 2007-05-05.16:07:53 |
|
Applied with a few small changes to 2.3 (r3204) and trunk (r3205).
- kz
|
| msg2582 (view) |
Author: Khalid Zuberi (kzuberi) |
Date: 2007-05-06.21:08:33 |
|
I foolishly pulled the trigger too quickly on this one, Charlie noted it causes test_quopri to fail. I reverted the change from trunk so as not to impact the beta. Its still in 2.3, can try to sort out the problems there. It seemed to do the wrong thing with trailing whitespace, and i think there are some other breakages.
Apologies for the sloppy commit.
- kz
|
| msg3596 (view) |
Author: Jim Baker (zyasoft) |
Date: 2008-09-14.06:52:40 |
|
Fixed in 2.5 with r4807
Tested with test_binascii
|
|
| Date |
User |
Action |
Args |
| 2008-09-14 06:52:40 | zyasoft | set | status: open -> closed
nosy:
+ zyasoft
resolution: fixed
messages:
+ msg3596
components:
+ Library, - None |
| 2007-01-03 11:48:50 | lmoore | create | |
|
