Issue1632

classification
Title: cPickle.Unpickler does not allow assignment of find_global
Type: behaviour Severity: normal
Components: Library Versions: 2.5.2b1
Milestone:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: zyasoft Nosy List: alex.gronholm, otmarhumbel, zyasoft
Priority: Keywords: patch

Created on 2010-07-12.11:52:25 by alex.gronholm, last changed 2010-08-09.21:25:27 by zyasoft.

Files
File name Uploaded Description Edit Remove
cPickle.diff alex.gronholm, 2010-07-12.11:52:23
pickletest.py alex.gronholm, 2010-07-12.11:53:31 Test script to verify correct operation
Messages
msg5886 (view) Author: Alex Grönholm (alex.gronholm) Date: 2010-07-12.11:52:23
According to Python documentation (http://docs.python.org/release/2.5.4/lib/pickle-sub.html), Unpickler objects from cPickle can use the find_global attribute (a callable) to decide what gets unpickled and what doesn't. Currently, however, this is incorrectly implemented in Jython so that Unpickler looks for the find_global attribute in the module, instead of the Unpickler instance.

Attached are the patch to correct this behavior, and a test script to verify the correct operation.
msg5891 (view) Author: Oti Humbel (otmarhumbel) Date: 2010-07-13.14:42:28
version change
msg5933 (view) Author: Jim Baker (zyasoft) Date: 2010-07-30.14:47:57
Reasonable patch
msg5949 (view) Author: Jim Baker (zyasoft) Date: 2010-08-09.21:25:27
Patch applied in r7088
History
Date User Action Args
2010-08-09 21:25:27zyasoftsetstatus: open -> closed
resolution: fixed
messages: + msg5949
2010-07-30 14:47:58zyasoftsetassignee: zyasoft
messages: + msg5933
nosy: + zyasoft
2010-07-13 14:42:29otmarhumbelsetmessages: + msg5891
versions: + 2.5.2b1, - 2.5.1
2010-07-12 11:53:31alex.gronholmsetfiles: + pickletest.py
2010-07-12 11:52:25alex.gronholmcreate