Issue1665260

classification
Title: Patch for [1661679] Invalid types.UnicodeType
Type: Severity: normal
Components: None Versions:
Milestone:
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: cgroves, hsk0
Priority: normal Keywords: patch

Created on 2007-02-21.14:33:40 by hsk0, last changed 2007-02-28.19:03:40 by cgroves.

Files
File name Uploaded Description Edit Remove
test_types.py hsk0, 2007-02-21.15:03:31 Added test case 6.7 Types module
Messages
msg2649 (view) Author: howard kapustein (hsk0) Date: 2007-02-21.14:33:40
See bug details @ http://sourceforge.net/tracker/index.php?func=detail&aid=1661679&group_id=12867&atid=112867

The fix (types.java=SVN, typeshk.java=Fixed):

--- types.java  2007-02-21 09:29:28.550870200 -0500
+++ typeshk.java        2007-02-21 09:29:24.581942400 -0500
@@ -50,7 +50,7 @@
         dict.__setitem__("TypeType", PyType.fromClass(PyJavaClass.class));
         dict.__setitem__("UnboundMethodType",
                          PyType.fromClass(PyMethod.class));
-        dict.__setitem__("UnicodeType", PyType.fromClass(PyString.class));
+        dict.__setitem__("UnicodeType", PyType.fromClass(PyUnicode.class));
         dict.__setitem__("XRangeType", PyType.fromClass(PyXRange.class));

         dict.__setitem__("StringTypes", new PyTuple(new PyObject[] {
msg2650 (view) Author: howard kapustein (hsk0) Date: 2007-02-21.15:03:32
I've attached a modified ...\Lib\test\test_types.py, adding test case 6.7 to verify the Types module. I modified the existing file but only added lines 764+

As there was a large existing test case I merely extended it rather than write a new JUnit test file.
File Added: test_types.py
msg2651 (view) Author: Charlie Groves (cgroves) Date: 2007-02-28.18:53:03
applied in r3126.
msg2652 (view) Author: Charlie Groves (cgroves) Date: 2007-02-28.19:03:40
I'm leaving the test_types modification out since I'm about to change a fair amount of that with the type system unification.
History
Date User Action Args
2007-02-21 14:33:40hsk0create