Issue1671304

classification
Title: Patch for string formatting bug #1671134
Type: Severity: normal
Components: None Versions:
Milestone:
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: cgroves, pekka.klarck
Priority: normal Keywords: patch

Created on 2007-02-28.22:52:41 by pekka.klarck, last changed 2007-03-09.17:23:57 by cgroves.

Files
File name Uploaded Description Edit Remove
format.patch pekka.klarck, 2007-02-28.22:52:41
format2.patch pekka.klarck, 2007-03-01.10:44:16
Messages
msg2671 (view) Author: Pekka Klärck (pekka.klarck) Date: 2007-02-28.22:52:41
This is a patch (incl. tests) for http://jython.org/bugs/1671134
msg2672 (view) Author: Pekka Klärck (pekka.klarck) Date: 2007-03-01.00:08:17
As I commented in the bug report this patch leaves "'%(x)s' % {'x':u'xxx'}" case open. Another problem I noticed is following. If the fix is in StringFormatter as I suggest in the report comments this problem will also be removed. 

>>> '%d' % 3
Traceback (innermost last):
  File "<console>", line 1, in ?
TypeError: iteration over non-sequence;

This one is of course something that I would've noticed if I had run all tests in the first place. Must learn to do that...
msg2673 (view) Author: Pekka Klärck (pekka.klarck) Date: 2007-03-01.10:44:17
Here's a new patch with fixes for problems mentioned here and in the bug report. The actual fix is now in StringFormatter.format.
File Added: format2.patch
msg2674 (view) Author: Charlie Groves (cgroves) Date: 2007-03-09.17:23:57
Committed in r3135.
History
Date User Action Args
2007-02-28 22:52:41pekka.klarckcreate