Issue1761111
Created on 2007-07-26.13:26:24 by rajesh_battala, last changed 2008-09-13.23:30:32 by zyasoft.
|
| File name |
Uploaded |
Description |
Edit |
Remove |
|
test_pep292.py
|
rajesh_battala,
2007-08-16.07:10:30
|
Test file for the patch |
|
|
|
patch_pep292.diff
|
rajesh_battala,
2007-08-20.05:01:37
|
|
|
|
|
| msg2739 (view) |
Author: rajesh battala (rajesh_battala) |
Date: 2007-07-26.13:26:24 |
|
hi all
i am attaching a tar which contains the patch for the PEP292 and test program for that.
thanks
rajesh.battala
|
| msg2740 (view) |
Author: Charlie Groves (cgroves) |
Date: 2007-07-30.04:45:53 |
|
This appears to be the PEP 292 stuff straight out of CPython. That's definitely the way to go, but I need to know the svn url and revision where you got this. We track when stuff came over from CPython so as we catch up to their current version we can just depend on that directly rather than having our own version in Jython.
Also, please submit this as a single patch file rather than as a tar.
|
| msg2741 (view) |
Author: rajesh battala (rajesh_battala) |
Date: 2007-07-30.05:16:44 |
|
hi charles.
i have taken that implementation from python version of 2.4
from python2.4 source ihave taken not from the svn repository. so, i am not sure of svn url and revision
i am attaching the patch. and it has to merge in Lib/string.py
thanks
File Added: pep292.patch
|
| msg2742 (view) |
Author: Frank Wierzbicki (fwierzbicki) |
Date: 2007-07-30.13:43:17 |
|
rajesh_battala,
The svn location of the CPython 2.4 maintenance branch is: http://svn.python.org/projects/python/branches/release24-maint
if you could check that out like so:
svn co http://svn.python.org/projects/python/branches/release24-maint
and confirm that your diff is the same against this and include a comment like:
#XXX: copied from http://svn.python.org/projects/python/branches/release24-maint revision 56629
That would help.
|
| msg2743 (view) |
Author: rajesh battala (rajesh_battala) |
Date: 2007-07-31.03:52:23 |
|
hi fwierzbicki
thanks a lot for the important useful comment
|
| msg2744 (view) |
Author: rajesh battala (rajesh_battala) |
Date: 2007-07-31.04:33:13 |
|
hi Charles Groves
this is the svn location http://svn.python.org/projects/python/branches/release24-maint revision 56629
and the file string.py is located in Lib
i have added the comments suggested my fwierzbicki in the patch.
i am submitting the patch as a single file
thanks.
File Added: pep292.patch
|
| msg2745 (view) |
Author: Charlie Groves (cgroves) |
Date: 2007-08-12.05:53:03 |
|
Hi Rajesh,
The patch seems to have lost the test file you included the first time. See http://wiki.python.org/jython/PatchGuidelines for instructions on how to produce a diff that includes your changes to string.py and the test file.
|
| msg2746 (view) |
Author: rajesh battala (rajesh_battala) |
Date: 2007-08-16.07:09:17 |
|
hi
i am attaching the patch for the String PEP292.
The test case file for this moudle is a new file test_pep292.py
so i am attaching it seperately.
thanks
File Added: pep292.patch
|
| msg2747 (view) |
Author: rajesh battala (rajesh_battala) |
Date: 2007-08-16.07:10:30 |
|
File Added: test_pep292.py
|
| msg2748 (view) |
Author: rajesh battala (rajesh_battala) |
Date: 2007-08-20.05:01:37 |
|
Diff take from the jython trunk
File Added: patch_pep292.diff
|
| msg3556 (view) |
Author: Jim Baker (zyasoft) |
Date: 2008-09-13.23:30:32 |
|
Fixed for 2.5 and tested by test_pep292
|
|
| Date |
User |
Action |
Args |
| 2008-09-13 23:30:32 | zyasoft | set | status: open -> closed
nosy:
+ zyasoft
resolution: fixed
messages:
+ msg3556 |
| 2007-07-26 13:26:24 | rajesh_battala | create | |
|
