Issue1762564
Created on 2007-07-28.08:53:17 by mehendran, last changed 2007-07-30.04:24:54 by cgroves.
|
| msg2765 (view) |
Author: Mehendran (mehendran) |
Date: 2007-07-28.08:53:17 |
|
patch for the bug [ 1758323 ]
plz, find the patch attached.
|
| msg2766 (view) |
Author: Charlie Groves (cgroves) |
Date: 2007-07-30.04:24:54 |
|
Applied with some minor changes in r3367.
PyNone is a singleton, so rather than checking instanceof PyNone to look for this, you can just use this.compare == Py.None. instanceof is more expensive than you'd think in Java, so it should be avoided where possible.
Also, I moved the check for None up into the constructor, and don't set compare if it's None. This saves making that check for every comparison.
Finally, for these types of bugs where I mention that a test is checking for it in the description, that means I've either disabled or commented out that portion of the test. It'd be good if you could find that portion of the test, reenable or uncomment it, and include that in your patch after assuring that it now passes. You should be able to search for the bug id number in the source to find any changes I've made for it.
|
|
| Date |
User |
Action |
Args |
| 2007-07-28 08:53:17 | mehendran | create | |
|
