Issue1765882

classification
Title: patch for :[ 1758315 ] org.python.modules.operator lacks is
Type: Severity: normal
Components: None Versions:
Milestone:
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: cgroves, ukeshav
Priority: normal Keywords: patch

Created on 2007-08-02.06:43:03 by ukeshav, last changed 2007-08-14.05:19:21 by cgroves.

Files
File name Uploaded Description Edit Remove
bug_1758315.diff ukeshav, 2007-08-13.11:05:46 patch file
Messages
msg2771 (view) Author: keshav upadhyaya (ukeshav) Date: 2007-08-02.06:43:03
i have added is_ and is_not function for checking identity . 
0
now test_operator is working fine..

msg2772 (view) Author: Charlie Groves (cgroves) Date: 2007-08-12.06:06:25
If test_operator is working fine, then renable the tests associated with this bug in there and include that in your patch.  You should renable the tests in test_bool as well.

Also, your patch is relative to the modules directory, not the root of a jython checkout.  See http://wiki.python.org/jython/PatchGuidelines for the things we want in a patch.
msg2773 (view) Author: keshav upadhyaya (ukeshav) Date: 2007-08-13.11:05:46
Hi Charles,
Now i am attaching a  patch taken form root along with the r-enabled test_operator and test_bool test files .

 
File Added: bug_1758315.diff
msg2774 (view) Author: Charlie Groves (cgroves) Date: 2007-08-14.05:19:21
Looks good!  Committed in r3415.
History
Date User Action Args
2007-08-02 06:43:03ukeshavcreate