Issue1772858

I have uploaded a patch for the bug 1768074 :str.replace() doesn't handle an empty string to be replaced.With this patch now str.replace does not throw ValueError on receiving an empty string as a parameter.Instead it's functionality on receiving an empty string is identical to it's behaviour in python

Thanks,
Ayesha

This patch doesn't enable the tests mentioned in the bug report, and when they are enabled, they fail.  See http://wiki.python.org/jython/VersionTransition for how to work on the bugs in the test failure causes group.

Also, this patch is relative to the core directory and uses tabs instead of spaces.  See http://wiki.python.org/jython/PatchGuidelines for instructions on making a patch.

i have attached a new modified patch which includes diff of both PyString.java and test case related to that.

File Added: patch_strreplace.diff

First, this patch still isn't following the instructions in the guidelines page on the wiki.  The two patch segments in it aren't relative to the root of a jython checkout, so they have to be specified manually.  See the bit about running svn diff from the base of a checkout.

Secondly, the tests you uncommented still fail.  string_tests are a set of tests run by test_str, test_userstring and test_unicode.  If you run any of them with your updated string_tests, you can see the failures.

I have attached a new patch. With this patch now all three tests are succeeding for str_replace .
Also for negative value of maxsplit given an empty string to be replaced this patch will return the same value for python and jython(this is not checked by the test files).
File Added: strreplace.patch

Applied in r3509.  Jython uses spaces instead of tabs for indentation, so I fixed that.