Issue1783160

classification
Title: Patch: compatibility with Eclipse compiler
Type: Severity: normal
Components: None Versions:
Milestone:
process
Status: closed Resolution: invalid
Dependencies: Superseder:
Assigned To: Nosy List: cgroves, david-perez
Priority: normal Keywords: patch

Created on 2007-08-28.09:43:31 by david-perez, last changed 2007-09-25.16:41:46 by cgroves.

Files
File name Uploaded Description Edit Remove
PyBuiltinMethodSet.java.patch david-perez, 2007-08-28.09:43:31
PySuper.java.patch david-perez, 2007-09-25.07:27:01
Messages
msg2834 (view) Author: David Pérez (david-perez) Date: 2007-08-28.09:43:31
Eclipse 3.3 compiler complains in several locations about this:

The field self is defined in an inherited type and an enclosing scope 

This is the explanation: http://dev.eclipse.org/newslists/news.eclipse.tools/msg60827.html
Luckily the solution is very easy.
msg2835 (view) Author: David Pérez (david-perez) Date: 2007-08-28.10:14:32
Run all tests successfully!
msg2836 (view) Author: Charlie Groves (cgroves) Date: 2007-09-22.11:28:34
This patch just seems to add a colon to an exception message in PyBuiltinMethodSet.  Hopefully Eclipse wasn't complaining about that :)  Was there supposed to be more to the patch?
msg2837 (view) Author: David Pérez (david-perez) Date: 2007-09-25.07:27:02
Sorry, that patch is for Java 1.3 compatibility.
The right patch is PySuper.java.patch
File Added: PySuper.java.patch
msg2838 (view) Author: Charlie Groves (cgroves) Date: 2007-09-25.16:41:46
Unfortunately, the patch modifies generated source code, so changing it by hand is a bad idea.  It'll just revert to its old state the next time the generator is run.  We're swapping out the generator in the next version of Jython, so it'll become moot then anyway.
History
Date User Action Args
2007-08-28 09:43:31david-perezcreate