Issue1785638

classification
Title: ImportError from zip without source
Type: Severity: normal
Components: Core Versions:
Milestone:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: japrox, pjenvey
Priority: normal Keywords:

Created on 2007-08-31.14:34:59 by japrox, last changed 2007-09-01.05:40:53 by pjenvey.

Files
File name Uploaded Description Edit Remove
importfromjar.zip japrox, 2007-08-31.14:35:00
Messages
msg1894 (view) Author: japrox (japrox) Date: 2007-08-31.14:34:59
Import from zip (without source) causes error.
See example in attached file.
msg1895 (view) Author: Philip Jenvey (pjenvey) Date: 2007-09-01.05:40:53
this issue is already fixed (just fixed today, actually) by the new zipimporter. trunk r3461, pre new zipimporter does:

pjenvey@golgo13-wireless:~/Desktop/Downloads/importfromjar$ jythont start_ok_fromdir.py 
RUN-OK
pjenvey@golgo13-wireless:~/Desktop/Downloads/importfromjar$ jythont start_ok_fromzip_source.py 
RUN-OK
pjenvey@golgo13-wireless:~/Desktop/Downloads/importfromjar$ jythont start_BAD_fromzip_nosource.py 
Traceback (innermost last):
  File "start_BAD_fromzip_nosource.py", line 5, in ?
ImportError: no module named mod1

trunk HEAD, r3464 (with new zipimporter):

pjenvey@golgo13-wireless:~/Desktop/Downloads/importfromjar$ jythont start_ok_fromdir.py 
RUN-OK
pjenvey@golgo13-wireless:~/Desktop/Downloads/importfromjar$ jythont start_ok_fromzip_source.py 
RUN-OK
pjenvey@golgo13-wireless:~/Desktop/Downloads/importfromjar$ jythont start_BAD_fromzip_nosource.py 
RUN1

RUN1 is displayed because the compiled $py.class in both zips actually prints RUN1, which is  a mismatch with the associated .py file that prints RUN-OK.

RUN1 isn't displayed for the zip with source because the uncompiled .py file in it actually has a later modification time than the compiled version

Thanks for logging this with the extensive test! Although the issue was already fixed, this was a nice little test for the brand new zipimporter that hasn't had much real world use yet
History
Date User Action Args
2007-08-31 14:34:59japroxcreate