Issue1838063

classification

Title:	Patch for [1796425] [1796415] javaos.py renames/removedirs
Type:		Severity:	normal
Components:	None	Versions:
		Milestone:

process

Status:	closed	Resolution:	duplicate
Dependencies:		Superseder:
Assigned To:		Nosy List:	cgroves, dohuiginn
Priority:	normal	Keywords:	patch

Created on 2007-11-25.13:26:28 by dohuiginn, last changed 2007-11-30.20:42:18 by cgroves.

Messages
msg2947 (view)	Author: Dan (dohuiginn)	Date: 2007-11-25.13:26:28
Patch to fix the issues reported in [1796425] and [1796415] - javaos is missing the renames and removedirs functions. I've copied the functions over from CPython (2.5) and they seem to work fine. Since this is the first patch I've submitted to jython, I'd appreciate advice/comments on what's required here. e.g. is the diff in the right format? should I write a test to go with the patch?
msg2948 (view)	Author: Charlie Groves (cgroves)	Date: 2007-11-25.19:54:58
Having tests for the patch makes it easier to apply them, so they're definitely encouraged. http://wiki.python.org/jython/PatchGuidelines has some basic guidelines for patches for Jython.
msg2949 (view)	Author: Charlie Groves (cgroves)	Date: 2007-11-30.20:42:18
http://jython.org/patches/1814683 also fixes this

History
Date	User	Action	Args
2007-11-25 13:26:28	dohuiginn	create