Issue1844733

classification
Title: Patch for [ 1841639 ] Filecmp module is not in jython
Type: Severity: normal
Components: None Versions:
Milestone:
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: Nosy List: cgroves, mehendran
Priority: normal Keywords: patch

Created on 2007-12-05.10:25:01 by mehendran, last changed 2007-12-10.00:22:20 by cgroves.

Files
File name Uploaded Description Edit Remove
module_filecmp.diff mehendran, 2007-12-05.10:25:01 filecmp module
Messages
msg2964 (view) Author: Mehendran (mehendran) Date: 2007-12-05.10:25:01
As jython implementation of os.stat call is limited in
returning the same values as with CPython, many of file
properties are assigned to default which is zero
including InodeProtectionMode. In CPython, 
InodeProtectionMode is to find out the type of the file
given. so, i have modified the filecmp module with the
support of java.io.File.

Now all the test cases are working properly. The patch is
attached herewith.

please give your valuable comments and suggestions.
msg2965 (view) Author: Charlie Groves (cgroves) Date: 2007-12-10.00:22:20
This patch adds a forked version of filecmp that will no longer work in CPython.  Rather than committing it, I upgraded os.stat to fill in st_mode with the bits needed for filecmp that you're figuring out with the patch.
History
Date User Action Args
2007-12-05 10:25:01mehendrancreate