Title: java.util.Map derived classes lack iterkeys, itervalues methods
Type: Severity: normal
Components: Versions: Jython 2.7
Milestone: Jython 2.7.1
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: jeff.allen Nosy List: dclayton, jeff.allen, zyasoft
Priority: normal Keywords:

Created on 2015-12-17.01:43:47 by zyasoft, last changed 2016-09-14.16:15:29 by zyasoft.

msg10541 (view) Author: Jim Baker (zyasoft) Date: 2015-12-17.01:43:46
But iteritems is implemented. See - it is trivial to add the missing methods

See related bug #1631 - these methods were not tested for by our tests in test_dict_jy and supported by CPython's test_dict. Are there others?
msg10727 (view) Author: Jim Baker (zyasoft) Date: 2016-02-08.15:55:11
Very good starter bug for someone who is interested in contributing to Jython
msg10757 (view) Author: Jim Baker (zyasoft) Date: 2016-02-18.04:49:29
PR in
msg10772 (view) Author: Jim Baker (zyasoft) Date: 2016-02-24.06:33:41
Review for inclusion into 2.7.1 now that we have a PR
msg10848 (view) Author: Doug Clayton (dclayton) Date: 2016-04-28.21:39:36
Any update on accepting the pull request? We've been using a custom build with the commit in the PR, and we haven't seen any issues with it.
msg10850 (view) Author: Jim Baker (zyasoft) Date: 2016-04-29.14:38:45
I'm sure we will get this in for 2.7.1, but higher priority bugs (+ for me, higher priority other aspects of life/work) have taken precedence. Sorry about this, we will wrap up 2.7.1 hopefully in May.
msg10920 (view) Author: Jeff Allen (jeff.allen) Date: 2016-08-28.17:05:52
I'll review, and assuming it's ok, commit in Doug's name from here.

(I don't have access to manage PRs on GitHub.)
msg10923 (view) Author: Jim Baker (zyasoft) Date: 2016-08-30.00:02:32
Jeff, please don't worry about managing the PRs on GitHub - assuming we accept the change, the only thing we do is close the PRs, after pushing the change against

I find using the .diff scheme very handy to get the diff. Example:

In 2.7.2, this workflow should hopefully change.
msg10925 (view) Author: Jeff Allen (jeff.allen) Date: 2016-08-31.07:04:30
This looks good to me and regrtest runs as expected. I evicted a couple of hard tabs: the whole source file needs a reformat anyway.

It might be objected that the guarantee about the order of separate iterators on the same container, offered here:
is not required of all implementations of java.util.Map. But this objection can be made against the existing code, and strictly speaking, the promise is made for dict, and it's only "recommended" that other mappings behave the same as dict.
msg10935 (view) Author: Jim Baker (zyasoft) Date: 2016-09-05.16:27:53
Fixed as of
Date User Action Args
2016-09-14 16:15:29zyasoftsetstatus: pending -> closed
2016-09-05 16:27:53zyasoftsetstatus: open -> pending
resolution: fixed
messages: + msg10935
2016-08-31 07:04:30jeff.allensetmessages: + msg10925
2016-08-30 00:02:33zyasoftsetmessages: + msg10923
2016-08-28 17:05:53jeff.allensetassignee: jeff.allen
messages: + msg10920
nosy: + jeff.allen
2016-04-29 14:38:46zyasoftsetmessages: + msg10850
2016-04-28 21:39:36dclaytonsetmessages: + msg10848
2016-02-24 06:33:41zyasoftsetpriority: normal
messages: + msg10772
milestone: Jython 2.7.2 -> Jython 2.7.1
2016-02-18 04:49:29zyasoftsetnosy: + dclayton
messages: + msg10757
2016-02-08 15:55:11zyasoftsetmessages: + msg10727
milestone: Jython 2.7.2
2015-12-17 01:43:47zyasoftcreate