Message10207

Author	stefan.richthofer
Recipients	stefan.richthofer, zyasoft
Date	2015-09-02.22:53:34
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1441234415.27.0.158924396894.issue2386@psf.upfronthosting.co.za>
In-reply-to

Content
Looking at tests/java/org/python/core/PySystemStateTest.java it appears that ignoring system-specific separator-chars is intended behavior. Maybe this was fine because it was internal API. However the leading "/" before the windows drive letter is not considered by the test and would let it fail on my system. My suggestion: Make this method protected in Py.java and leave its behavior as it is for internal use. Maybe fix the leading "/" in windows case, I'm not sure - would be good to hear someone who is more confident about this. Then I would create a slightly renamed public version that replaces "/" by system-specific separators.

Looking at tests/java/org/python/core/PySystemStateTest.java
it appears that ignoring system-specific separator-chars is intended behavior. Maybe this was fine because it was internal API. However the leading "/" before the windows drive letter is not considered by the test and would let it fail on my system.

My suggestion: Make this method protected in Py.java and leave its behavior as it is for internal use. Maybe fix the leading "/" in windows case, I'm not sure - would be good to hear someone who is more confident about this.
Then I would create a slightly renamed public version that replaces "/" by system-specific separators.

History
Date	User	Action	Args
2015-09-02 22:53:35	stefan.richthofer	set	messageid: <1441234415.27.0.158924396894.issue2386@psf.upfronthosting.co.za>
2015-09-02 22:53:35	stefan.richthofer	set	recipients: + stefan.richthofer, zyasoft
2015-09-02 22:53:35	stefan.richthofer	link	issue2386 messages
2015-09-02 22:53:34	stefan.richthofer	create