Message1024

Author pedronis
Recipients
Date 2005-08-19.21:51:44
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
Logged In: YES 
user_id=61408

oversights on my part.

the first problem doesn't happen if X is new-style, the
issue is that PyClass doesn't define fastGetDict, see
patch_lost_attr

the second problem is more subtle, old-style classes should
have logic such that if one of the bases is not old-style
its type should be used as metaclass. This cannot be put in
the constructor of PyClass logic because a constructor
cannot return some new instances to substute.

patch_cast_problem puts such logic in Py.makeClass, it
should be the right place but better check whether other
places instatiating PyClass may need a change too (in that
case we need an helper or they should use makeClass instead).

I'm attaching patches and not checking in myself directly
because tonight I have no time to run all the tests and
check all places where PyClass is instantiated. Tomorrow I'm
leaving for a week in Germany for a PyPy sprint.
History
Date User Action Args
2008-02-20 17:17:25adminlinkissue1264260 messages
2008-02-20 17:17:25admincreate